Skip to content

Conversation

ewdurbin
Copy link
Member

No description provided.

@di di force-pushed the require_verified_email branch from aba2067 to c332fac Compare April 1, 2024 13:10
@di di marked this pull request as ready for review April 1, 2024 14:02
@di di requested a review from a team as a code owner April 1, 2024 14:02
@di di requested a review from miketheman April 1, 2024 14:04
@ewdurbin
Copy link
Member Author

ewdurbin commented Apr 1, 2024

I can't put a review on cause I started the PR, but ✅. I'd like to see us consolidate the macros into base_manage now that we have two templates but that can be a follow on.

@di di requested a review from miketheman April 1, 2024 15:22
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to move forward, since the extra lines in check_for_mfa should have no use and can be removed later if needed.

@di di merged commit 3f9e0e2 into main Apr 1, 2024
@di di deleted the require_verified_email branch April 1, 2024 16:10
@pypi pypi deleted a comment from sentry-io bot Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants